Re: [PATCH v3 5/8] git-prompt: add some missing quotes
- From
avih <avihpit@yahoo.com>
- Date
- Aug 17, 2024, 10:07 UTC
- Message-ID
- <12028161.4698975.1723889226498@mail.yahoo.com>
- In-Reply-To
- <CAPig+cQVHVoDFD484dxu2gOuvzVHj9-78pyTnCo2-uy6=N5P-g@mail.gmail.com>
On Saturday, August 17, 2024 at 12:38:23 PM GMT+3, Eric Sunshine <sunshine@sunshineco.com> wrote:
> On Sat, Aug 17, 2024 at 5:26 AM Avi Halachmi (:avih) via GitGitGadget >> Listing some portability guideline here for future reference. > >> s/guideline/guidelines/
Right.
>> I'm leaving it to someone else to decide whether to include >> it in the file itself, place is as a new file, or not. > > perhaps: s/is as/it as/
Indeed.
Show 5 quoted lines
>> "Simple command" (POSIX term) is assignment[s] and/or command [args]. >> Examples: >> ... > > This new explanation in v3 is a helpful addition.
Thanks.
Show 5 quoted lines
>> The arguments to "local" do look like assignments, but they're not >> the assignment part of a simple command. they're at the command part. > > either: s/they're/They're/ > or: s/. they're/; they're/
Indeed. Thanks for the comments.
> I doubt that any of the above extremely minor commit message botches > is worth a reroll.
I'm not the one to judge that, but I'm OK to push as many new versions as deemed required/preferred. For now I'm waiting for someone to say whether I should do that or not... and if yes - when.
I was trying to wait few days for more comments on v2 (perhaps like yours), but I noticed that v2 was already was just integrated into "seen", so I posted v3 to address the existing comments on v2.
This is my 1st patch to "git", so still finding my feet with the procedures.
avih