Re: [PATCH v2 4/8] git-prompt: replace [[...]] with standard code
- From
avih <avihpit@yahoo.com>
- Date
- Aug 16, 2024, 10:36 UTC
- Message-ID
- <1371885213.4494853.1723804592269@mail.yahoo.com>
- In-Reply-To
- <xmqqsev5u4yr.fsf@gitster.g>
On Thursday, August 15, 2024 at 07:27:12 PM GMT+3, Junio C Hamano <gitster@pobox.com> wrote:
Show 8 quoted lines
>> From: "Avi Halachmi (:avih)" <avihpit@yahoo.com> >> >> The existing [[...]] tests were either already valid as standard [...] >> tests, or only required minimal retouch: > > FWIW, our local coding guidelines to spell these with "test" > (without closing "]"), but this change certainly is a good first > step to get rid of non-portable "[[ ... ]]" construct.
Right. I did see that, though only after I wrote the patch.
FWIW, the common form in this file was "[" (46 instances), then "[[" (13 instances), and finally "test" (3 instances).
So I'd still think changing "[[" forms into "[" is the better choice for this file in a compatibility-focused change, as it leaves the file in a mostly consistent usage of "[" throughout.
There can come later another change to tighten adherence to the guidelines.
But if you want to revise this commit and use "test" instead of "[[", just let me know and I'll do that. I'd be fine with that.
In such case, should we also change the existing "[" at the file to "test"? (in a new commit?)