Re: [PATCH v3 5/8] git-prompt: add some missing quotes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 17, 2024, 16:28 UTC
- Message-ID
- <xmqqcym7i05l.fsf@gitster.g>
- In-Reply-To
- <12028161.4698975.1723889226498@mail.yahoo.com>
avih <avihpit@yahoo.com> writes:
> I was trying to wait few days for more comments on v2 (perhaps > like yours), but I noticed that v2 was already was just integrated > into "seen", so I posted v3 to address the existing comments on v2.
Please consider that it is just like being on the list and nothing else to be in "seen". It merely is another place some patches I've "seen" are published, to help those of you who find "git fetch && git log -pW origin/master..origin/topic" a more convenient way to review the changes. This is outlined in the note I send out occasionally.
https://lore.kernel.org/git/xmqqmslewwpo.fsf@gitster.g/
If you think that v2 needs a few more days' exposure to receive more feedback from reviewers, and that v3 might be incomplete before waiting for their feedback, just saying so as a response to the "What's cooking" message is a very effective way to make sure I'll wait for an updated iteration. Such a comment on individual topics is *not* limited to the author of the topic, e.g.
https://lore.kernel.org/git/owlyil264yew.fsf@fine.c.googlers.com/
is an example (but the particular example was sent a bit too late---such a "wait, don't merge, an update is coming" needs to come before the topic is merged down to 'next'.
https://lore.kernel.org/git/13f08ce5-f036-f769-1ba9-7d47b572af28@gmail.com/
is an example of a reviewer sending a "stop, I have an improvement to suggest on this one I'll send soon" on a topic by somebody else.
https://lore.kernel.org/git/Zr2_4sNu56_frqlr@tanuki/
is an example of the author saying "this topic of mine should be complete already", which is a bit less usual and takes some finesse to avoid sounding too self-promoting (this particular example does so well).