Re: [PATCH v3 5/8] git-prompt: add some missing quotes

From: avih <avihpit@yahoo.com>
Date: Aug 17, 2024, 18:02 UTC
Message-ID: <301312741.4747142.1723917755269@mail.yahoo.com>
In-Reply-To: <xmqqcym7i05l.fsf@gitster.g>

 On Saturday, August 17, 2024 at 07:28:44 PM GMT+3, Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> avih <avihpit@yahoo.com> writes:
>> I was trying to wait few days for more comments on v2 (perhaps
>> like yours), but I noticed that v2 was already was just integrated
>> into "seen", so I posted v3 to address the existing comments on v2.
>
> Please consider that it is just like being on the list and nothing
> else to be in "seen".  It merely is another place some patches I've
> "seen" are published, to help those of you who find "git fetch &&
> git log -pW origin/master..origin/topic" a more convenient way to
> review the changes.  This is outlined in the note I send out
> occasionally.
>
>     https://lore.kernel.org/git/xmqqmslewwpo.fsf@gitster.g/

Thanks for the time and info. That's a useful intro, and I now do see it says this:

  until a topic is merged to "next", updates to it is expected
  by replacing the patch(es) in the topic with an improved version

Show 10 quoted lines

> If you think that v2 needs a few more days' exposure to receive more
> feedback from reviewers, and that v3 might be incomplete before
> waiting for their feedback, just saying so as a response to the
> "What's cooking" message is a very effective way to make sure I'll
> wait for an updated iteration.  Such a comment on individual topics
> is *not* limited to the author of the topic, e.g.
>
>   https://lore.kernel.org/git/owlyil264yew.fsf@fine.c.googlers.com/
>
> is an example ...

Thanks. I replied few times that requested changes will be included in v3, so I thought it's apparent that v3 is sill to come, but in retrospect, when you replied to [PATCH v2 0/8]:

> I've read the series and they looked all sensible.  Will queue but
> I'd appreciate a second set of eyes before marking it for 'next'.

Then I should have replied with something along those lines:

  Please wait for v3 with requested non-critical changes (typos in
  comment and commit message) before moving it to "next", if at all.

or even sending the same message once I noticed it was merged into "seen", instead of posting v3 out of "panic" that it boarded the train without all the requested changes applied, yes?

If yes, then here's heads-up that there's still another non-critical requested change to arrive in v4 (commit message wording), which I'll send in few days, to allow for further comments to arrive.

Because resending the whole series (is that "reroll"?) for every minor typo or wording change feels noisy and inappropriate to me.

Thanks again for the time and info.

avih