Re: [GSoC PATCH v8 5/5] repo: add the --format flag
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 7, 2025, 15:44 UTC
- Message-ID
- <xmqqjz3frv9i.fsf@gitster.g>
- In-Reply-To
- <aJQ3tyC0e53iWtVE@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 6 quoted lines
>> + default:
>> + BUG("%d: not a valid output format", format);
>
> Nit: we typically say it the other way round.
>
> BUG("not a valid output format: %d", format);It is in the coding guidelines
- Say what the error is first ("cannot open '%s'", not "%s: cannot open").but sometimes we forget. Thanks for good eyes.