Re: [GSoC RFC PATCH v2 1/7] repo-info: declare the repo-info command

From: Karthik Nayak <karthik.188@gmail.com>
Date: Jun 23, 2025, 09:19 UTC
Message-ID: <CAOLa=ZSewCtgRnuLV1GPfLccFqcnNac1AT6vG8ghOquNqXsoZQ@mail.gmail.com>
In-Reply-To: <xmqq4iwa0xzz.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 19 quoted lines

> Karthik Nayak <karthik.188@gmail.com> writes:
>
>>>  .gitignore          |  1 +
>>>  Makefile            |  1 +
>>>  builtin.h           |  1 +
>>>  builtin/repo-info.c | 21 +++++++++++++++++++++
>>>  git.c               |  1 +
>>>  meson.build         |  1 +
>>>  6 files changed, 26 insertions(+)
>>>  create mode 100644 builtin/repo-info.c
>>>
>>
>> Something I mentioned in the previous review, but hasn't been addressed
>> is the addition of documentation for the new command. With each patch
>> modifying the command, it would be also nice to add the respective
>> documentation.
>
> Bsdies, the lack of Documentation/repo-info.adoc causes "make check-docs"
> fail.

More so the reason, I didn't know the target also checks for missing documentation. That is great!