Re: [GSoC PATCH v5 1/5] repo: declare the repo command
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Jul 27, 2025, 20:20 UTC
- Message-ID
- <CAPig+cRwv1xOoiXRBo0tECXPKV=BrHo_aHcD6Wy+mOUv4OvuJA@mail.gmail.com>
- In-Reply-To
- <20250727175110.84770-2-lucasseikioshiro@gmail.com>
On Sun, Jul 27, 2025 at 1:51 PM Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> wrote:
Show 16 quoted lines
> Currently, `git rev-parse` covers a wide range of functionality not > directly related to parsing revisions, as its name suggests. Over time, > many features like parsing datestrings, options, paths, and others > were added to it because there wasn't a more appropriate command > to place them. > > Create a new Git command called `repo`. `git repo` will be the main > command for obtaining the information about a repository (such as > metadata and metrics). > > Also declare a subcommand for `repo` called `info`. `git repo info` > will bring the functionality of retrieving repository-related > information currently returned by `rev-parse`. > > Add the required tests, documentation and build changes to enable > usage of this subcommand.
This talks about adding tests, however...
Show 12 quoted lines
> Signed-off-by: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> > --- > .gitignore | 1 + > Documentation/git-repo.adoc | 38 +++++++++++++++++++++++++++++++++++++ > Documentation/meson.build | 1 + > Makefile | 1 + > builtin.h | 1 + > builtin/repo.c | 26 +++++++++++++++++++++++++ > command-list.txt | 1 + > git.c | 1 + > meson.build | 1 + > 9 files changed, 71 insertions(+)
...no tests are added.
Show 5 quoted lines
> diff --git a/Documentation/git-repo.adoc b/Documentation/git-repo.adoc > @@ -0,0 +1,38 @@ > +DESCRIPTION > +----------- > +This command retrieve repository level information.
s/retrieve/retrieves/
I'm a native English speaker, but I wonder if, rather than "repository level", it would be more friendly to non-native speakers to instead say:
Retrieve information about the repository.