Re: [GSoC PATCH v7 2/5] repo: add the field references.format

From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date: Aug 3, 2025, 21:47 UTC
Message-ID: <DC57657C-41E9-4DCA-AA7E-9DC5ADB2DC40@gmail.com>
In-Reply-To: <CAPig+cTxNUPayO2SdCL-BPtjb2rfr3e3RK=BsQxAiiEAtpBaRg@mail.gmail.com>

> This logic leads to a poor user-experience if the user asks for the
> same non-existent key multiple times since that case subverts the
> deduplication logic.

Makes sense. I'll change it in v8.

> is unnecessarily confusing and difficult to fathom because it is
> repurposing the strubuf and increasing the number of allocations and
> deallocations for no apparent reason.

Agreed. Given that the strings that I'm storing are relatively small, it won't hurt to have two strbufs. I'll incorporate your suggestion.

> The function documentation (including "Usage") talks about four
> arguments, but the function expects five.

I changed the parameters but I forgot to change the docs. I'll change it in v8.

> I'm having trouble understanding what is meant by "repository named
> with its first argument accordingly to what is being tested".

Indeed, this is confusing. Actually, this solution of using `eval "$init_command $repo_name"` is quite fragile. I'll change it to a more robust solution.

> These tests are easier to understand and are more robust in this version. Good.

Thanks, Eric. Your reviews were really helpful for making these tests better!