From: Junio C Hamano Date: Thu, 07 Aug 2025 15:44:57 GMT Subject: Re: [GSoC PATCH v8 5/5] repo: add the --format flag Message-ID: In-Reply-To: Patrick Steinhardt writes: >> + default: >> + BUG("%d: not a valid output format", format); > > Nit: we typically say it the other way round. > > BUG("not a valid output format: %d", format); It is in the coding guidelines - Say what the error is first ("cannot open '%s'", not "%s: cannot open"). but sometimes we forget. Thanks for good eyes.