Re: [GSoC PATCH v9 3/5] repo: add the field layout.bare

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 14, 2025, 23:41 UTC
Message-ID: <CAPig+cSkAqJ23ESdFeUePAuAB=j0N+NsrdEiW4onQpU9Sbki_A@mail.gmail.com>
In-Reply-To: <1ABC1E05-BEE9-4E17-8C6C-8BB4127378BF@gmail.com>

On Thu, Aug 14, 2025 at 6:18 PM Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> wrote:

Show 18 quoted lines

> > I also care about future-proofing, though.  When Git is built with
> > WITH_BREAKING_CHANGES=YesPlease, this test would break as the
> > default reference backend will be reftable in that alternate world,
> > wouldn't it?
>
> To be honest, it wouldn't matter what are the keys selected for
> testing this behavior. I'm only using references.format because it
> was the first that I implemented. But given that, I can also change
> their order to something like:
>
> [1/5] repo: declare the repo command
> [2/5] repo: add the field layout.bare
> [3/5] repo: add the field layout.shallow
> [2/5] repo: add the field references.format
> [5/5] repo: add the --format flag
>
> This way, this tests could be placed in 3/5 and using layout.bare and
> layout.shallow as keys.

I don't have a strong preference since I think you already future-proofed the test by using `--ref-format=files` with the git-init invocation, but the above suggested patch order would work, as well, and seems sufficiently reviewer-friendly.