Re: [GSoC PATCH v5 2/5] repo: add the field references.format

From: Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date: Jul 31, 2025, 19:49 UTC
Message-ID: <3EC7AA57-9863-4F7C-BBB6-D40978CE2748@gmail.com>
In-Reply-To: <aIiV7cz2Tx50JZUv@pks.im>

> And the call to `strbuf_release()` should be moved to the end of this
> function so that we know to reuse the buffer. The above early return
> would then be converted into a `goto out` so that we have a common exit
> path where we know to clean up all resources.

I agree, however, after Eric's suggestion of keep looping even if find an invalid key, that goto will now be a continue.

But I'll use strbuf_reset and move the strbuf_release to the end of the function in the next version.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.