Re: [PATCH v7 4/4] libgit: add higher-level libgit crate

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2025, 21:17 UTC
Message-ID: <xmqqikpymydi.fsf@gitster.g>
In-Reply-To: <iexpjuyxdg3yzk2eeibtzfgyzzrnpo2fg2ic6eeajky5lm7elw@tby4wimoqjrg>

Josh Steadmon <steadmon@google.com> writes:

Show 10 quoted lines

>> I somehow would have expected this part of the patch to do
>> 
>> 	libgit-sys libgit-rs:
>> 		$(QUIET)( \
>> 			cd contrib/$@ && cargo build \
>> 		)
>> 
>> but the above longhand is fine.
>
> Fixed since I'm sending out a V8 for Phillip's feedback anyway. Thanks.

It would be a "fix" only if we anticipate that we will add in the future more Rust things to contrib/ and all of them would follow the same pattern. Otherwise, it does not really matter, and as I said, what you posted is just fine.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.