Re: [RFC PATCH 3/6] contrib/cgit-rs: introduce Rust wrapper for libgit.a

From: Mike Hommey <mh@glandium.org>
Date: Aug 8, 2024, 00:17 UTC
Message-ID: <20240808001743.4sx32gbjtypq3rje@glandium.org>
In-Reply-To: <njekhcypd7x7vdxmkzbdbeblwm4bwiiz74saxdmzqeod6zz547@qkkwkmpjvwkd>

On Wed, Aug 07, 2024 at 04:29:54PM -0700, Josh Steadmon wrote:

Show 5 quoted lines

> > You might as well use `dst.display()`.
> 
> Wouldn't that fail silently in the event that the path is non-UTF-8? I
> think I'd prefer to explicitly fail in that case, even if it seems
> unlikely.

That's the theory, unfortunately, reality is that even the most central Rust crates don't care: https://github.com/rust-lang/cc-rs/blob/main/src/lib.rs#L1357-L1360

Even better, last time I tried, cargo or rustc (I don't remember which one it was) would blatantly fail to work if the path is not UTF-8 in the first place.

Mike

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.