Re: [PATCH v4 5/5] Makefile: add option to build and test libgit-rs and libgit-rs-sys

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 10, 2024, 00:52 UTC
Message-ID: <xmqq7cagok3j.fsf@gitster.g>
In-Reply-To: <yynolodpcv43doqcab4bin7z7gembixqfhvqdzpcoeipnyjwl4@ek3gr4l2ycrr>

Josh Steadmon <steadmon@google.com> writes:

Show 6 quoted lines

> Hmm, I think this may be an unfortunate interaction between Git's `make
> all`, followed by libgit-sys's `build.rs` calling make again (with
> different CFLAGS, specifically '-fvisibility=hidden') to build
> libgitpub.a. So then the second `make all` has to rebuild everything due
> to changing the CFLAGS back, and then libgit-sys has to rebuild
> libgitpub.a once again.

Ah, OK, if we need to compile in two different ways, then it is a matter of giving a dedicated *.o build directory to each, and until that happens, the object files for Git proper and libgit-sys would try to stomp on each other.

I thought Patrick's build procedure update has out-of-tree build as one of its goals, in which case we may be able to piggy-back on the effort once it starts to stabilize.

Thanks.