Re: [PATCH v8 0/4] Introduce libgit-rs, a Rust wrapper around libgit.a

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Jan 29, 2025, 15:24 UTC
Message-ID: <6ed6cf83-070c-4be2-b58d-398006cbb072@gmail.com>
In-Reply-To: <cover.1738101256.git.steadmon@google.com>

Hi Josh

On 28/01/2025 22:01, Josh Steadmon wrote:

Thanks for re-rolling, the range-diff looks good to me apart from

Show 6 quoted lines

>       +void libgit_configset_free(struct libgit_config_set *cs)
>       +{
>      -+	git_configset_clear((struct config_set *) cs);
>      -+	free((struct config_set *) cs);
>      ++	git_configset_clear(&cs->cs);
>      ++	free(&cs->cs);

Which I think should be "free(cs)". In practice it does not matter because we pass the same value to free() but it seems a bit odd to pass the address of the first member of the struct rather than the address of the struct itself.

I'm looking forward to seeing this merged soon

Best Wishes

Phillip

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.