RE: [PATCH v4 5/5] Makefile: add option to build and test libgit-rs and libgit-rs-sys

From: rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date: Oct 9, 2024, 00:12 UTC
Message-ID: <02a401db19df$eaca75e0$c05f61a0$@nexbridge.com>
In-Reply-To: <xmqqed4qxior.fsf@gitster.g>

On October 8, 2024 7:46 PM, Junio C Hamano wrote:

Show 7 quoted lines

>Josh Steadmon <steadmon@google.com> writes:
>
>> Add environment variable, INCLUDE_LIBGIT_RS, that when set,
>> automatically builds and tests libgit-rs and libgit-rs-sys when `make
>> all` is ran.
>
>Is this unusual, or is it just like how other makefile macros like say

USE_NSEC (to

>cause the resulting Git to use subsecond mtimes) are meant to be used to

control

>the build?  IOW, shouldn't this be documented near the top of the Makefile,

e.g.

Show 7 quoted lines

>
>    diff --git i/Makefile w/Makefile
>    index 41ad458aef..2b55fe9672 100644
>    --- i/Makefile
>    +++ w/Makefile
>    @@ -392,6 +392,9 @@ include shared.mak
>     # INSTALL_STRIP can be set to "-s" to strip binaries during

installation,

Show 8 quoted lines

>     # if your $(INSTALL) command supports the option.
>     #
>    +# Define INCLUDE_LIBGIT_RS if you want your gostak to distim
>    +# the doshes and ...
>    +#
>     # Define GENERATE_COMPILATION_DATABASE to "yes" to generate JSON
>compilation
>     # database entries during compilation if your compiler supports it,

using the

>     # `-MJ` flag. The JSON entries will be placed in the

`compile_commands/`

>
>It might make sense to follow naming convention to call it NO_RUST and flip

its

>polarity.  Those who do not have or want libgit-rs and friends can say

NO_RUST but

>otherwise it gets built by default.  It would give you a wider developer

population

>coverage.

Some of us who do not have Rust (yet) approve this message. I hope our situation will change on having Rust on NonStop.