Re: [PATCH v3 4/6] config: add git_configset_alloc() and git_configset_clear_and_free()

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Sep 10, 2024, 08:50 UTC
Message-ID: <c8d65466-a9c3-4556-84c1-3daf0c7cea14@gmail.com>
In-Reply-To: <Zt_qM8ZGN4fnqUoY@pks.im>

On 10/09/2024 07:41, Patrick Steinhardt wrote:

> Is there ever a case where one wants to
> allocate the configset, but not use it?

That was my thought too - I suggested providing git_configset_new() that would allocate and initialize a config set in my response to the last round [1]. It is good to see that the struct in now namespaced in the next patch but separating out allocation and initialization makes the api harder to use than it needs to be. I'd also like to see git_configset_clear_and_free() become git_configset_free().

Best Wishes

Phillip

[1] https://lore.kernel.org/git/47b18fa4-f01b-4f42-8d04-9e145515ccc1@gmail.com

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.