Re: [PATCH v3 3/6] libgit-sys: add repo initialization and config access

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 6, 2024, 23:45 UTC
Message-ID: <xmqq8qw4uz1q.fsf@gitster.g>
In-Reply-To: <20240906222116.270196-3-calvinwan@google.com>

Calvin Wan <calvinwan@google.com> writes:

Show 8 quoted lines

> Wrap a few repo setup and config access functions in libgit-sys. These
> were selected as proof-of-concept items to show that we can access local
> config from Rust.
>
> Co-authored-by: Josh Steadmon <steadmon@google.com>
> Signed-off-by: Calvin Wan <calvinwan@google.com>
> Change-Id: I6dd886af8c63e1f0f3251064cd8903aecdf768bb
> ---

Common to all other steps, I suspect that you meant to but forgot to strip out the Change-Id: thing here?

Also there are a few whitespace breakages in this step.

Applying: libgit-sys: add repo initialization and config access
.git/rebase-apply/patch:129: trailing whitespace.
         * for the existence of a key rather than a specific value
.git/rebase-apply/patch:138: trailing whitespace.
        unsafe {
.git/rebase-apply/patch:143: trailing whitespace.
        unsafe {
warning: 3 lines add whitespace errors.

There is another one in a later step.

Applying: libgit: add higher-level libgit crate
.git/rebase-apply/patch:325: trailing whitespace.
        // ConfigSet retrieves correct value
warning: 1 line adds whitespace errors.