Re: [RFC PATCH 0/6] [RFC] Introduce cgit-rs, a Rust wrapper around libgit.a
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 9, 2024, 19:22 UTC
- Message-ID
- <xmqqbk21cxhn.fsf@gitster.g>
- In-Reply-To
- <cover.1723054623.git.steadmon@google.com>
Josh Steadmon <steadmon@google.com> writes:
> We're sending this series as RFC because there is remaining work > we'd like to do, but we'd like to get early feedback on this approach, > and particularly to ask for advice on a few topics:
I am not sure how much this is reusable, after seeing comments that "cgit-rs" may not be the best name for this thing and pathnames may have to change, but I needed the following merge-fix to get this into "seen" and have the result pass "make", due to interactions with the ps/config-wo-the-repository topic.
contrib/cgit-rs/public_symbol_export.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/contrib/cgit-rs/public_symbol_export.c b/contrib/cgit-rs/public_symbol_export.c index 9641afca89..2732f5898e 100644 --- a/contrib/cgit-rs/public_symbol_export.c +++ b/contrib/cgit-rs/public_symbol_export.c @@ -9,6 +9,8 @@ #include "setup.h" #include "version.h" +extern struct repository *the_repository; + #pragma GCC visibility push(default) const char *libgit_setup_git_directory(void) @@ -18,7 +20,7 @@ const char *libgit_setup_git_directory(void) int libgit_config_get_int(const char *key, int *dest) { - return git_config_get_int(key, dest); + return repo_config_get_int(the_repository, key, dest); } void libgit_initialize_the_repository(void)
-- 2.46.0-326-g1e046905fc