Re: [PATCH 00/12] upload-pack: use 'struct upload_pack_data' thoroughly, part 2

From: Junio C Hamano <gitster@pobox.com>
Date: May 27, 2020, 20:41 UTC
Message-ID: <xmqqblm9kt4p.fsf@gitster.c.googlers.com>
In-Reply-To: <20200527185700.GJ4020820@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> One thing I think we _could_ do is to switch v2 to only reading the
> config once, instead of once per request. And then all of those config
> values could remain where they are, as they wouldn't need to be cleared
> or reset. But I doubt the cost of parsing config per-request is
> noticeable in practice, so I'm happy with it either way.

Yeah, I agree that that would not be an optimization for performance, but the value of doing it primarily lies in gaining the conceptual clarity in the resulting code.

Thanks, both.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.