Re: [PATCH 00/13] upload-pack: use 'struct upload_pack_data' thoroughly, part 1

From: Christian Couder <christian.couder@gmail.com>
Date: May 19, 2020, 09:49 UTC
Message-ID: <CAP8UFD36xWw152YyGQtskZESndC-=TEUYC1S5ckqvgMp7wd6Ww@mail.gmail.com>
In-Reply-To: <2860708f-2719-50b1-f1ae-7fd9c0538c52@gmail.com>

On Fri, May 15, 2020 at 12:43 PM Derrick Stolee <stolee@gmail.com> wrote:

>
> On 5/15/2020 6:04 AM, Christian Couder wrote:

Show 11 quoted lines

> > While there are still a lot of static variables at the top of
> > 'upload-pack.c' after this patch series, it does a lot of ground work
> > and a number of cleanups.
>
> The patches here are carefully organized to make review easy. Thanks!
>
> I was surprised to see how many local or static variables you were able
> to remove using members that already existed in 'struct upload_pack_data'.
> That made the changes here particularly easy to trust.
>
> Reviewed-by: Derrick Stolee <dstolee@microsoft.com>

Thanks for your review and kind words! I would very much like to add your "Reviewed-by:" to this patch series, but as no suggestion has been made to improve it, I am a bit reluctant to resend with only your "Reviewed-by:" added.

Junio, what would you prefer?

Thanks, Christian.