Re: [PATCH 10/12] upload-pack: move allow_ref_in_want to upload_pack_data

From: Jeff King <peff@peff.net>
Date: May 27, 2020, 18:41 UTC
Message-ID: <20200527184118.GH4020820@coredump.intra.peff.net>
In-Reply-To: <20200527164742.23067-11-chriscool@tuxfamily.org>

On Wed, May 27, 2020 at 06:47:40PM +0200, Christian Couder wrote:

Show 8 quoted lines

> As we cleanup 'upload-pack.c' by using 'struct upload_pack_data'
> more thoroughly, let's move the 'allow_ref_in_want' static
> variable into this struct.
> 
> It is only used by protocol v0 code since protocol v2 assumes
> certain baseline capabilities, but rolling it into
> upload_pack_data and just letting v2 code ignore it as it does
> now is more coherent and cleaner.

I think this is opposite, isn't it? Ref-in-want is a v2-only feature, and v0 does not support it at all (though it could).

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.