From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 27 May 2020 20:41:42 GMT
Subject: Re: [PATCH 00/12] upload-pack: use 'struct upload_pack_data' thoroughly, part 2
Message-ID: <xmqqblm9kt4p.fsf@gitster.c.googlers.com>
In-Reply-To: <20200527185700.GJ4020820@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> One thing I think we _could_ do is to switch v2 to only reading the
> config once, instead of once per request. And then all of those config
> values could remain where they are, as they wouldn't need to be cleared
> or reset. But I doubt the cost of parsing config per-request is
> noticeable in practice, so I'm happy with it either way.

Yeah, I agree that that would not be an optimization for
performance, but the value of doing it primarily lies in
gaining the conceptual clarity in the resulting code.

Thanks, both.