Re: [PATCH 03/12] upload-pack: move use_sideband to upload_pack_data

From: Jeff King <peff@peff.net>
Date: May 27, 2020, 18:07 UTC
Message-ID: <20200527180727.GB4020820@coredump.intra.peff.net>
In-Reply-To: <20200527164742.23067-4-chriscool@tuxfamily.org>

On Wed, May 27, 2020 at 06:47:33PM +0200, Christian Couder wrote:

Show 8 quoted lines

> As we cleanup 'upload-pack.c' by using 'struct upload_pack_data'
> more thoroughly, let's move the 'use_sideband' static variable
> into this struct.
> 
> This variable is used by both v0 and v2 protocols.
> 
> While at it, let's update the comment near the variable
> definition.

Yep, looks good. I was surprised for a moment by "used by v2", which always does sideband. But of course we still _use_ the variable, we just set it unconditionally in the v2 code-path.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.