Re: [PATCH 06/12] upload-pack: change multi_ack to an enum

From: Jeff King <peff@peff.net>
Date: May 27, 2020, 18:10 UTC
Message-ID: <20200527181008.GD4020820@coredump.intra.peff.net>
In-Reply-To: <20200527164742.23067-7-chriscool@tuxfamily.org>

On Wed, May 27, 2020 at 06:47:36PM +0200, Christian Couder wrote:

Show 6 quoted lines

> As we cleanup 'upload-pack.c' by using 'struct upload_pack_data'
> more thoroughly, let's take this opportunity to change the
> 'multi_ack' variable, which is now part of 'upload_pack_data',
> to an enum.
> 
> This will make it clear which values this variable can take.

Much nicer, thanks for doing this cleanup.

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.