Re: [PATCH 00/14] upload-pack: use 'struct upload_pack_data' thoroughly, part 3

From: Jonathan Tan <jonathantanmy@google.com>
Date: Jun 11, 2020, 20:04 UTC
Message-ID: <20200611200456.102655-1-jonathantanmy@google.com>
In-Reply-To: <20200611120518.10771-1-chriscool@tuxfamily.org>

Show 9 quoted lines

> This patch series is the third and last part of an effort to move all
> static variables in 'upload-pack.c' into 'struct upload_pack_data'.
> 
> It is based on 'cc/upload-pack-data-2' which contains "part 2" of this
> effort.
> 
> There are no static variables left in 'upload-pack.c' after this patch
> series. Patch 14/14 is a small refactoring on top which can be left
> out.

Thanks. Overall, I see that this patch set gives "struct upload_pack_data" to functions that use global variables (and in doing so, shrinks their parameter list), enabling global variables to be moved into that struct with a small diff. The changes are generally mechanical, and this patch set looks good to me.

As an aside, I have attempted rebasing my CDN offloading patches [1] from cc/upload-pack-data-2 onto this series, and the rebase succeeds with trivial work needed.

[1] https://lore.kernel.org/git/cover.1591821067.git.jonathantanmy@google.com/