Re: [PATCH v3 00/13] upload-pack: use 'struct upload_pack_data' thoroughly, part 2

From: Christian Couder <christian.couder@gmail.com>
Date: Jun 5, 2020, 10:38 UTC
Message-ID: <CAP8UFD3tnNxs3LVyyZtkZY7h_fJ8_+T1vV_j3sDJmAypKQ534Q@mail.gmail.com>
In-Reply-To: <xmqq7dwmpuwa.fsf@gitster.c.googlers.com>

On Thu, Jun 4, 2020 at 8:07 PM Junio C Hamano <gitster@pobox.com> wrote:

>
> Christian Couder <christian.couder@gmail.com> writes:

Show 5 quoted lines

> > There is a lot of noise in the range-diff with V2, because V3 contains
> > Peff's 'Acked-by:' and Junio's 'Signed-off-by', but here it is:
>
> Would it work as a "trick" to fetch what has been queued in 'pu' and
> compare against that lets you avoid such a "noise", I wonder?

Yeah, probably. I will try it next time.

Show 5 quoted lines

> If it
> works well, it would have an added benefit of having the
> publically-known commit object names on the left hand side
> (e.g. instead of e5c31f30ec, you'd see d293806610 as the patch 1
> from the second iteration) of the range-diff.

Yeah, thanks for the suggestion!

By the way another issue I had was that for some reason send-email inserted a "From: Christian Couder <christian.couder@gmail.com>" line at the beginning of each patch. Sorry about that.