git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 6/6] SubmittingPatches: note that trailer order matters

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 10, 2026, 22:30 UTC
Message-ID
<xmqq8q8mt4eo.fsf@gitster.g>
In-Reply-To
<trailer_order_matters.8f9@msgid.xyz>
kristofferhaugsbakk@fastmail.com writes:
Show 32 quoted lines
> From: Kristoffer Haugsbakk <code@khaugsbakk.name>
>
> It matters where you put the s-o-b; it should be last. You are signing
> off on the patch as well as the whole message up to that point.
>
> This also makes it clear who added what:
>
>     Acked-by: The Reviewer <r@example.org>
>     Signed-off-by: The Contributor <c@example.org>
>     Acked-by: The (Late) Reviewer <late@example.org>
>     Signed-off-by: The Maintainer <m@example.org>
>
> The the first ack was added by the contributor and the second one was
> added by the maintainer.
>
> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
> ---
>  Documentation/SubmittingPatches | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 3d2e9ecfbb8..2045708bdf5 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -490,6 +490,11 @@ particular are not used in this project.
>  Only capitalize the very first letter of the trailer, i.e. favor
>  `Signed-off-by:` over `Signed-Off-By:` and `Acked-by:` over `Acked-By:`.
>  
> +Note that these trailers should come before your `Signed-off-by:`
> +trailer. You are signing off to the patch as well as the message. This
> +also makes it clear who added trailers when multiple people have signed
> +off on a patch.

Perhaps first mention the underlying rule that they are added in the order that helps us to understand the chronological order of events. That would avoid giving a wrong impression that the nature of each trailer keys determine the order of these lines.

Thanks.
Previous: kristofferhaugsbakk@fastmail.comNext: Kristoffer Haugsbakk
Message 17 of 32 in “SubmittingPatches: update and flesh out trailer sections”
  1. 0/6 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  2. 1/6 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  3. Junio C HamanoJun 11, 2026
  4. Kristoffer HaugsbakkJun 16, 2026
  5. 2/6 SubmittingPatches: discuss non-ident trailerskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  6. Patrick SteinhardtJun 12, 2026
  7. Kristoffer HaugsbakkJun 16, 2026
  8. Patrick SteinhardtJun 17, 2026
  9. Kristoffer HaugsbakkJun 17, 2026
  10. 3/6 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  11. Junio C HamanoJun 11, 2026
  12. 4/6 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  13. Junio C HamanoJun 11, 2026
  14. Kristoffer HaugsbakkJun 16, 2026
  15. 5/6 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  16. 6/6 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  17. Junio C HamanoJun 10, 2026
  18. Kristoffer HaugsbakkJun 16, 2026
  19. 0/5 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  20. 1/5 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  21. Junio C HamanoJun 17, 2026
  22. Kristoffer HaugsbakkJun 18, 2026
  23. 2/5 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  24. 3/5 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  25. 4/5 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  26. 5/5 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  27. 0/5 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 19, 2026
  28. 1/5 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  29. 2/5 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 19, 2026
  30. 3/5 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  31. 4/5 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  32. 5/5 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.