Re: [PATCH 1/6] SubmittingPatches: encourage trailer use for substantial help
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Jun 16, 2026, 20:14 UTC
- Message-ID
- <310ef65e-b6c7-4d0c-a58a-0c88257143ba@app.fastmail.com>
- In-Reply-To
- <xmqq1pedowl2.fsf@gitster.g>
On Thu, Jun 11, 2026, at 18:44, Junio C Hamano wrote:
Show 5 quoted lines
> kristofferhaugsbakk@fastmail.com writes: > >> Let’s replace “If you like” with outright encouragment in this section > > "encouragement"?
Yep.
Show 5 quoted lines
> >> At the same, it is important to temper this recommendation to a sign- >> ificant enough contribution; in my experience beginners can be eager > > "At the same time"?
Yep.
> > It is a bit unusual to see a long word split at the end of a line > to line-wrap in our documentation and commit log messages.
A bit unusual is an understatement. I cannot find any other commit log message writers that have split a word on a syllable. All linebreaks that I’ve found are on existing hyphens. Like
... multi-pack-
indexesI’ll avoid this in the future.
Show 6 quoted lines
> >> --- >> Documentation/SubmittingPatches | 14 +++++++++++--- >> 1 file changed, 11 insertions(+), 3 deletions(-) > > The patch text itself looks great. Thanks.
Thanks for going over these.