Re: [PATCH 4/6] SubmittingPatches: document Based-on-patch-by trailer
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Jun 16, 2026, 20:07 UTC
- Message-ID
- <e0bd8fb9-d34e-43d4-b3e0-f2a4b8d6a7a8@app.fastmail.com>
- In-Reply-To
- <xmqqse6tnho1.fsf@gitster.g>
On Thu, Jun 11, 2026, at 18:52, Junio C Hamano wrote:
Show 10 quoted lines
> kristofferhaugsbakk@fastmail.com writes: > >> +. `Based-on-patch-by:` can be used when someone else authored parts of >> + the patch that you are submitting. This might be relevant if someone >> + sent a patch to the mailing list without a commit message or a >> + `Signed-off-by:` and you have picked it up. > > Hmph, this seems to encourage pick up material that come outside of > the usual DCO process, which should not be the intention of this > document.
Oh, I have misread the room on this subject. It would be better to drop the mention of signoff here.
Show 6 quoted lines
> > Unless the changes are trivial enough to not be copyrightable, it > may be better to say "... if someone submitted a preliminary patch or > a detailed code snippet with their sign-off", plus encourage asking > the original author to sign-off if it initially came without, or > something like that?
Okay, since they provided something concrete to copy (cf. Helped-by where they did not provide precise changes in patch form, according to the below context), it’s best to mention that signoff is relevant here.
> >> . `Helped-by:` is used to credit someone who suggested ideas for >> changes without providing the precise changes in patch form. >> . `Mentored-by:` is used to credit someone with helping develop a