git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 4/6] SubmittingPatches: document Based-on-patch-by trailer

From
KHKristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date
Jun 16, 2026, 20:07 UTC
Message-ID
<e0bd8fb9-d34e-43d4-b3e0-f2a4b8d6a7a8@app.fastmail.com>
In-Reply-To
<xmqqse6tnho1.fsf@gitster.g>
On Thu, Jun 11, 2026, at 18:52, Junio C Hamano wrote:
Show 10 quoted lines
> kristofferhaugsbakk@fastmail.com writes:
>
>> +. `Based-on-patch-by:` can be used when someone else authored parts of
>> +  the patch that you are submitting. This might be relevant if someone
>> +  sent a patch to the mailing list without a commit message or a
>> +  `Signed-off-by:` and you have picked it up.
>
> Hmph, this seems to encourage pick up material that come outside of
> the usual DCO process, which should not be the intention of this
> document.

Oh, I have misread the room on this subject. It would be better to drop the mention of signoff here.

Show 6 quoted lines
>
> Unless the changes are trivial enough to not be copyrightable, it
> may be better to say "... if someone submitted a preliminary patch or
> a detailed code snippet with their sign-off", plus encourage asking
> the original author to sign-off if it initially came without, or
> something like that?

Okay, since they provided something concrete to copy (cf. Helped-by where they did not provide precise changes in patch form, according to the below context), it’s best to mention that signoff is relevant here.

>
>>  . `Helped-by:` is used to credit someone who suggested ideas for
>>    changes without providing the precise changes in patch form.
>>  . `Mentored-by:` is used to credit someone with helping develop a
Previous: Junio C HamanoNext: kristofferhaugsbakk@fastmail.com
Message 14 of 32 in “SubmittingPatches: update and flesh out trailer sections”
  1. 0/6 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  2. 1/6 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  3. Junio C HamanoJun 11, 2026
  4. Kristoffer HaugsbakkJun 16, 2026
  5. 2/6 SubmittingPatches: discuss non-ident trailerskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  6. Patrick SteinhardtJun 12, 2026
  7. Kristoffer HaugsbakkJun 16, 2026
  8. Patrick SteinhardtJun 17, 2026
  9. Kristoffer HaugsbakkJun 17, 2026
  10. 3/6 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  11. Junio C HamanoJun 11, 2026
  12. 4/6 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  13. Junio C HamanoJun 11, 2026
  14. Kristoffer HaugsbakkJun 16, 2026
  15. 5/6 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  16. 6/6 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  17. Junio C HamanoJun 10, 2026
  18. Kristoffer HaugsbakkJun 16, 2026
  19. 0/5 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  20. 1/5 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  21. Junio C HamanoJun 17, 2026
  22. Kristoffer HaugsbakkJun 18, 2026
  23. 2/5 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  24. 3/5 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  25. 4/5 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  26. 5/5 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  27. 0/5 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 19, 2026
  28. 1/5 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  29. 2/5 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 19, 2026
  30. 3/5 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  31. 4/5 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  32. 5/5 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.