From: Junio C Hamano Date: Wed, 10 Jun 2026 22:30:07 GMT Subject: Re: [PATCH 6/6] SubmittingPatches: note that trailer order matters Message-ID: In-Reply-To: kristofferhaugsbakk@fastmail.com writes: > From: Kristoffer Haugsbakk > > It matters where you put the s-o-b; it should be last. You are signing > off on the patch as well as the whole message up to that point. > > This also makes it clear who added what: > > Acked-by: The Reviewer > Signed-off-by: The Contributor > Acked-by: The (Late) Reviewer > Signed-off-by: The Maintainer > > The the first ack was added by the contributor and the second one was > added by the maintainer. > > Signed-off-by: Kristoffer Haugsbakk > --- > Documentation/SubmittingPatches | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches > index 3d2e9ecfbb8..2045708bdf5 100644 > --- a/Documentation/SubmittingPatches > +++ b/Documentation/SubmittingPatches > @@ -490,6 +490,11 @@ particular are not used in this project. > Only capitalize the very first letter of the trailer, i.e. favor > `Signed-off-by:` over `Signed-Off-By:` and `Acked-by:` over `Acked-By:`. > > +Note that these trailers should come before your `Signed-off-by:` > +trailer. You are signing off to the patch as well as the message. This > +also makes it clear who added trailers when multiple people have signed > +off on a patch. Perhaps first mention the underlying rule that they are added in the order that helps us to understand the chronological order of events. That would avoid giving a wrong impression that the nature of each trailer keys determine the order of these lines. Thanks.