Re: [PATCH 4/6] SubmittingPatches: document Based-on-patch-by trailer
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 11, 2026, 16:52 UTC
- Message-ID
- <xmqqse6tnho1.fsf@gitster.g>
- In-Reply-To
- <Based-on-patch-by.8f7@msgid.xyz>
kristofferhaugsbakk@fastmail.com writes:
> +. `Based-on-patch-by:` can be used when someone else authored parts of > + the patch that you are submitting. This might be relevant if someone > + sent a patch to the mailing list without a commit message or a > + `Signed-off-by:` and you have picked it up.
Hmph, this seems to encourage pick up material that come outside of the usual DCO process, which should not be the intention of this document.
Unless the changes are trivial enough to not be copyrightable, it may be better to say "... if someone submitted a preliminary patch or a detailed code snippet with their sign-off", plus encourage asking the original author to sign-off if it initially came without, or something like that?
> . `Helped-by:` is used to credit someone who suggested ideas for > changes without providing the precise changes in patch form. > . `Mentored-by:` is used to credit someone with helping develop a