[PATCH 6/6] SubmittingPatches: note that trailer order matters
- From
- kristofferhaugsbakk@fastmail.com <kristofferhaugsbakk@fastmail.com>
- Date
- Jun 10, 2026, 22:22 UTC
- Message-ID
- <trailer_order_matters.8f9@msgid.xyz>
- In-Reply-To
- <CV_SubPatches_trailers.8f3@msgid.xyz>
From: Kristoffer Haugsbakk <code@khaugsbakk.name>
It matters where you put the s-o-b; it should be last. You are signing off on the patch as well as the whole message up to that point.
This also makes it clear who added what:
Acked-by: The Reviewer <r@example.org>
Signed-off-by: The Contributor <c@example.org>
Acked-by: The (Late) Reviewer <late@example.org>
Signed-off-by: The Maintainer <m@example.org>The the first ack was added by the contributor and the second one was added by the maintainer.
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name> --- Documentation/SubmittingPatches | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index 3d2e9ecfbb8..2045708bdf5 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -490,6 +490,11 @@ particular are not used in this project. Only capitalize the very first letter of the trailer, i.e. favor `Signed-off-by:` over `Signed-Off-By:` and `Acked-by:` over `Acked-By:`. +Note that these trailers should come before your `Signed-off-by:` +trailer. You are signing off to the patch as well as the message. This +also makes it clear who added trailers when multiple people have signed +off on a patch. + [[ai]] === Use of Artificial Intelligence (AI)
-- 2.54.0.22.g9e26862b904