git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 5/5] SubmittingPatches: note that trailer order matters

From
Kkristofferhaugsbakk@fastmail.com <kristofferhaugsbakk@fastmail.com>
Date
Jun 17, 2026, 20:52 UTC
Message-ID
<V2_trailer_order_matters.9bb@msgid.xyz>
In-Reply-To
<V2_CV_SubPatches_trailers.9b6@msgid.xyz>
From: Kristoffer Haugsbakk <code@khaugsbakk.name>

It matters where you put new trailers: they should be added in chronological order, and each person who passes on a patch should add their s-o-b last. You are signing off on the patch as well as the whole message up to that point.

This also makes it clear who added what:
    Acked-by: The Reviewer <r@example.org>
    Signed-off-by: The Contributor <c@example.org>
    Acked-by: The (Late) Reviewer <late@example.org>
    Signed-off-by: The Maintainer <m@example.org>

The first ack was added by the contributor and the second one was added by the maintainer.

Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
Notes (series):
    v2:
    • Mention this in both the DCO section (new) as well as the trailers
      section
    • Emphasize and lead with chronological order and let everything
      fall in place according to that
        • https://lore.kernel.org/git/xmqq8q8mt4eo.fsf@gitster.g/
    • Msg: Drop “the the”; one is enough
 Documentation/SubmittingPatches | 10 ++++++++++
 1 file changed, 10 insertions(+)
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index cb2df3cfff6..dceeb5a1817 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -427,6 +427,10 @@ D-C-O.  Indeed you are encouraged to do so.  Do not forget to
 place an in-body "From: " line at the beginning to properly attribute
 the change to its true author (see (2) above).
 
+Place this `Signed-off-by:` trailer at the end, after trailers added by
+others and after other trailers added by you; see
+<<commit-trailers,Commit trailers>> below ("chronological order").
+
 This procedure originally came from the Linux kernel project, so our
 rule is quite similar to theirs, but what exactly it means to sign-off
 your patch differs from project to project, so it may be different
@@ -487,6 +491,12 @@ particular are not used in this project.
 Only capitalize the very first letter of the trailer, i.e. favor
 `Signed-off-by:` over `Signed-Off-By:` and `Acked-by:` over `Acked-By:`.
 
+As mentioned under <<dco,DCO>> above, trailers are added in
+chronological order; one person might sign-off on a patch and send it to
+someone else, who then in turn adds her own sign-off. Further, any
+trailers that you add beyond your sign-off should come before that
+sign-off. That makes it clear what trailers which person added.
+
 [[ai]]
 === Use of Artificial Intelligence (AI)
 
-- 
2.54.0.22.g9e26862b904
Previous: kristofferhaugsbakk@fastmail.comNext: kristofferhaugsbakk@fastmail.com
Message 26 of 32 in “SubmittingPatches: update and flesh out trailer sections”
  1. 0/6 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  2. 1/6 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  3. Junio C HamanoJun 11, 2026
  4. Kristoffer HaugsbakkJun 16, 2026
  5. 2/6 SubmittingPatches: discuss non-ident trailerskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  6. Patrick SteinhardtJun 12, 2026
  7. Kristoffer HaugsbakkJun 16, 2026
  8. Patrick SteinhardtJun 17, 2026
  9. Kristoffer HaugsbakkJun 17, 2026
  10. 3/6 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  11. Junio C HamanoJun 11, 2026
  12. 4/6 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  13. Junio C HamanoJun 11, 2026
  14. Kristoffer HaugsbakkJun 16, 2026
  15. 5/6 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  16. 6/6 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  17. Junio C HamanoJun 10, 2026
  18. Kristoffer HaugsbakkJun 16, 2026
  19. 0/5 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  20. 1/5 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  21. Junio C HamanoJun 17, 2026
  22. Kristoffer HaugsbakkJun 18, 2026
  23. 2/5 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  24. 3/5 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  25. 4/5 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  26. 5/5 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  27. 0/5 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 19, 2026
  28. 1/5 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  29. 2/5 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 19, 2026
  30. 3/5 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  31. 4/5 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  32. 5/5 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.