git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/5] SubmittingPatches: encourage trailer use for substantial help

From
KHKristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date
Jun 18, 2026, 12:21 UTC
Message-ID
<afc9c132-252f-41de-bd20-7f3ed5fc136f@app.fastmail.com>
In-Reply-To
<xmqq4ij0vo8f.fsf@gitster.g>
On Wed, Jun 17, 2026, at 23:41, Junio C Hamano wrote:
Show 27 quoted lines
> kristofferhaugsbakk@fastmail.com writes:
>
>> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
>> index 176567738d4..0b12badf86d 100644
>> --- a/Documentation/SubmittingPatches
>> +++ b/Documentation/SubmittingPatches
>> @@ -443,8 +443,16 @@ identifying, and not misleading.
>>  The goal of this policy is to allow us to have sufficient information to contact
>>  you if questions arise about your contribution.
>>
>> +=== Commit trailers
>>  [[commit-trailers]]
>> -If you like, you can put extra trailers at the end:
>
> I think majority of AsciiDoc files in this project places [[anchor]]
> before the "=== title" of a section.  For example, here is how the
> patch flow section begins in SubmittingPatches:
>
>     [[patch-flow]]
>     === A typical life cycle of a patch series
>
>     To help us understand the reason behind various guidelines given later
>     in the document, first let's understand how the life cycle of a
>     typical patch series for this project goes.
>
> I do not offhand know which way is kosher, but we should be
> consistent either way.

Your suspicion is correct. Skimming this I cannot seem to find any examples where the anchor goes after the title.

    git grep --extended-regexp -C1 '^\[\[' -- 'Documentation/*adoc'
I’ll fix it.
Previous: Junio C HamanoNext: kristofferhaugsbakk@fastmail.com
Message 22 of 32 in “SubmittingPatches: update and flesh out trailer sections”
  1. 0/6 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  2. 1/6 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  3. Junio C HamanoJun 11, 2026
  4. Kristoffer HaugsbakkJun 16, 2026
  5. 2/6 SubmittingPatches: discuss non-ident trailerskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  6. Patrick SteinhardtJun 12, 2026
  7. Kristoffer HaugsbakkJun 16, 2026
  8. Patrick SteinhardtJun 17, 2026
  9. Kristoffer HaugsbakkJun 17, 2026
  10. 3/6 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  11. Junio C HamanoJun 11, 2026
  12. 4/6 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  13. Junio C HamanoJun 11, 2026
  14. Kristoffer HaugsbakkJun 16, 2026
  15. 5/6 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 10, 2026
  16. 6/6 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 10, 2026
  17. Junio C HamanoJun 10, 2026
  18. Kristoffer HaugsbakkJun 16, 2026
  19. 0/5 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  20. 1/5 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  21. Junio C HamanoJun 17, 2026
  22. Kristoffer HaugsbakkJun 18, 2026
  23. 2/5 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  24. 3/5 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  25. 4/5 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 17, 2026
  26. 5/5 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 17, 2026
  27. 0/5 SubmittingPatches: update and flesh out trailer sectionskristofferhaugsbakk@fastmail.com, Jun 19, 2026
  28. 1/5 SubmittingPatches: encourage trailer use for substantial helpkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  29. 2/5 SubmittingPatches: discourage common Linux trailerskristofferhaugsbakk@fastmail.com, Jun 19, 2026
  30. 3/5 SubmittingPatches: document Based-on-patch-by trailerkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  31. 4/5 SubmittingPatches: be consistent with trailer markupkristofferhaugsbakk@fastmail.com, Jun 19, 2026
  32. 5/5 SubmittingPatches: note that trailer order matterskristofferhaugsbakk@fastmail.com, Jun 19, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.