Re: [PATCH v2 1/5] SubmittingPatches: encourage trailer use for substantial help
- From
- Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
- Date
- Jun 18, 2026, 12:21 UTC
- Message-ID
- <afc9c132-252f-41de-bd20-7f3ed5fc136f@app.fastmail.com>
- In-Reply-To
- <xmqq4ij0vo8f.fsf@gitster.g>
On Wed, Jun 17, 2026, at 23:41, Junio C Hamano wrote:
Show 27 quoted lines
> kristofferhaugsbakk@fastmail.com writes: > >> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches >> index 176567738d4..0b12badf86d 100644 >> --- a/Documentation/SubmittingPatches >> +++ b/Documentation/SubmittingPatches >> @@ -443,8 +443,16 @@ identifying, and not misleading. >> The goal of this policy is to allow us to have sufficient information to contact >> you if questions arise about your contribution. >> >> +=== Commit trailers >> [[commit-trailers]] >> -If you like, you can put extra trailers at the end: > > I think majority of AsciiDoc files in this project places [[anchor]] > before the "=== title" of a section. For example, here is how the > patch flow section begins in SubmittingPatches: > > [[patch-flow]] > === A typical life cycle of a patch series > > To help us understand the reason behind various guidelines given later > in the document, first let's understand how the life cycle of a > typical patch series for this project goes. > > I do not offhand know which way is kosher, but we should be > consistent either way.
Your suspicion is correct. Skimming this I cannot seem to find any examples where the anchor goes after the title.
git grep --extended-regexp -C1 '^\[\[' -- 'Documentation/*adoc'
I’ll fix it.