Re: [PATCH 2/4] http: drop support for curl < 7.16.0

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 9, 2017, 17:40 UTC
Message-ID: <xmqq1sok7i82.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170809120157.il4ktf75wscqoyic@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> -#if LIBCURL_VERSION_NUM >= 0x071700
> -/* Use CURLOPT_KEYPASSWD as is */
> -#elif LIBCURL_VERSION_NUM >= 0x070903
> -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPASSWD
> -#else
> -#define CURLOPT_KEYPASSWD CURLOPT_SSLCERTPASSWD
> -#endif
> -

This part I am not sure. Don't we still need to substitute CURLOPT_KEYPASSWD with CURLOPT_SSLKEYPASSWD for versions below 071700, e.g. 071000 which is 7.16.0?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.