Re: [PATCH 2/5] http: correct curl version check for CURLOPT_PINNEDPUBLICKEY

From: Jeff King <peff@peff.net>
Date: Sep 10, 2021, 14:30 UTC
Message-ID: <YTtsDGs7j2lM+hh+@coredump.intra.peff.net>
In-Reply-To: <YTtpWADzTJEAIvk+@coredump.intra.peff.net>

On Fri, Sep 10, 2021 at 10:19:04AM -0400, Jeff King wrote:

Show 9 quoted lines

> But there is one thing that does get weird if we don't do this patch. If
> we later take the approach of checking:
> 
>   #ifdef CURLOPT_PINNEDPUBLICKEY
> 
> then that will subtly shift the cutoff point from 7.44 to 7.39 anyway.
> _If_ we are going to do that conversion in a later patch (as this series
> does), I think it makes sense to shift the version number explicitly in
> a commit with an explanation, as this commit does.

Ah, nevermind. I just saw Ævar's re-roll where that strategy turns out to be a bad idea anyway. So that is no longer a compelling argument. :)

-Peff

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.