Re: [PATCH 3/5] http: correct version check for CURL_HTTP_VERSION_2_0

From: Jeff King <peff@peff.net>
Date: Sep 8, 2021, 19:27 UTC
Message-ID: <YTkOlcfx8qwSBZ4A@coredump.intra.peff.net>
In-Reply-To: <patch-3.5-d8192164937-20210908T152807Z-avarab@gmail.com>

On Wed, Sep 08, 2021 at 05:31:54PM +0200, Ævar Arnfjörð Bjarmason wrote:

Show 13 quoted lines

> In d73019feb44 (http: add support selecting http version, 2018-11-08)
> a dependency was added on CURL_HTTP_VERSION_2_0, but this feature was
> introduced in curl version 7.43.0, not 7.47.0, as the incorrect
> version check led us to believe.
> 
> As looking through the history of that commit on the mailing list will
> reveal[1], the reason for this is that an earlier version of it
> depended on CURL_HTTP_VERSION_2TLS, which was introduced in libcurl
> 7.47.0.
> 
> But the version that made it in in d73019feb44 had dropped the
> dependency on CURL_HTTP_VERSION_2TLS, but the corresponding version
> check was not corrected.

According to the curl manpage, if we use CURL_HTTP_VERSION_2_0 instead, it goes all the way to 7.33.0. I don't have opinion on whether that's worth covering or not.

-Peff