Re: [PATCH v4 0/9] post-v2.33 "drop support for ancient curl" follow-up

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 13, 2021, 17:41 UTC
Message-ID: <xmqq4kaogyq1.fsf@gitster.g>
In-Reply-To: <YT+EH1O+kPrf4T8j@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 8 quoted lines

> On Mon, Sep 13, 2021 at 04:51:20PM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> This is a hopefully final re-roll with a small grammar improvement in
>> 3/8. See range-diff, pointed out/requested at
>> https://lore.kernel.org/git/YTzBUFY4p6obEqF+@coredump.intra.peff.net/
>
> Well, I did say "no need to re-roll". :) But thank you for addressing
> it. This version looks good to me.

Yup, the word-diff from what was queued with a !fixup step looks pleasing ;-)

Will replace.

Let me mark it for 'next' in the What's cooking report.

Thanks.

$ git diff --word-diff @{1}

diff --git c/INSTALL w/INSTALL
index 5865e1630d..4140a3f5c8 100644
--- c/INSTALL
+++ w/INSTALL
@@ -144,9 +144,9 @@ Issues of note:
	  not need that functionality, use NO_CURL to build without
	  it.

	  Git requires version "7.19.4" or later of "libcurl" to build
	  without NO_CURL. This version requirement may be bumped in
	  the future.

	- "expat" library; git-http-push uses it for remote lock
	  management over DAV.  Similar to "curl" above, this is optional