From: Junio C Hamano Date: Wed, 09 Aug 2017 17:40:13 GMT Subject: Re: [PATCH 2/4] http: drop support for curl < 7.16.0 Message-ID: In-Reply-To: <20170809120157.il4ktf75wscqoyic@sigill.intra.peff.net> Jeff King writes: > -#if LIBCURL_VERSION_NUM >= 0x071700 > -/* Use CURLOPT_KEYPASSWD as is */ > -#elif LIBCURL_VERSION_NUM >= 0x070903 > -#define CURLOPT_KEYPASSWD CURLOPT_SSLKEYPASSWD > -#else > -#define CURLOPT_KEYPASSWD CURLOPT_SSLCERTPASSWD > -#endif > - This part I am not sure. Don't we still need to substitute CURLOPT_KEYPASSWD with CURLOPT_SSLKEYPASSWD for versions below 071700, e.g. 071000 which is 7.16.0?