git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/5] drop support for ancient curl

From
Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date
Jul 23, 2021, 07:17 UTC
Message-ID
<87h7gltrst.fsf@evledraar.gmail.com>
In-Reply-To
<YPn3jP0n+ghomSkX@camp.crustytoothpaste.net>
On Thu, Jul 22 2021, brian m. carlson wrote:
Show 14 quoted lines
> [[PGP Signed Part:Undecided]]
> On 2021-07-22 at 07:09:59, Ævar Arnfjörð Bjarmason wrote:
>> I'll clarify this along with other fixes in a re-roll, but I think our
>> policy shouldn't have anything to do with upstream promises of support,
>> but merely the trade-off of how easy it is for us to support old
>> software & how likely it is that people use it in practice along with
>> git.
>
> I don't think I agree.  We should try to support major operating systems
> well provided we can adequately be expected to test on them, and that
> means that they should have publicly available security support.  In
> other words, a developer on the relevant operating system should be able
> to test on that OS without paying ongoing money for the privilege of doing
> so securely.

Doesn't drawing that line in the sand for Linux distributions by implication leave out support for Windows, OSX and any other proprietary system? You need to pay for security and other updates for those from day one.

Show 5 quoted lines
> Once an operating system is no longer supported security-wise, we should
> no longer support it, either, since we can't be expected to test or
> develop on it securely.  Nobody could responsibly run such an image on
> a CI system or test with it on an Internet-connected computer, so we
> should no longer consider it worthy of our support.

Yes, I do think we disagree. I just think we should focus narrowly on whether it's a hassle for us to support older libcurl, whether some version of it is packaged with an old OS that's known to be in wide use or not is ultimately just a useful heuristic.

Show 11 quoted lines
>> So as an example we still say we support Perl 5.8, which is ridiculously
>> ancient as far as any notion of upstream security support goes (and as
>> an aside, does have real DoS issues exposed by e.g. the gitweb we ship).
>> 
>> But while we could probably bump that to something more modern nowadays
>> in practice we're not a mostly-Perl project, so I haven't found it to be
>> worth it to bump it when working on the relevant code.
>
> I've actually argued in favor of bumping the version to 5.14 a long time
> ago.  I can send a patch for that.  It has a bunch of nice new features
> we could take advantage of.

Sure, I'm not opposed. Just noting the in-tree nicer features for us v.s. more aggressive versioning policy for packagers and users (not that Perl 5.14 is aggressive).

Show 26 quoted lines
>> I'm only using RHEL 5 as a shorthand for a system that's usually the
>> most ancient thing people want to build new gits with in practice.
>> 
>> It's just not the case that you can't run RHEL 5 or even RHEL 4 "safely"
>> even today. Upstream has just abandoned it, but that doesn't mean users
>> in the wild have. There's also CentOS, not everyone cares about IBM
>> corporate support policies.
>
> Yes, and CentOS has dropped support earlier than Red Hat has.
>
> Just because users want to run new versions of Git on systems that
> should long ago have been abandoned[0] does not mean we should take the
> burden of maintaining that code for them.  Since they have the source
> code, they can build and maintain Git on those old systems and apply
> any necessary patches.  If this becomes burdensome, then perhaps the
> cost of maintaining the system will be an incentive to replace it with a
> secure system.
>
> I am unconvinced that we should make it easier for people to run
> insecure operating systems because they pose a hazard to the Internet
> when connected to it.  Just because it is behind some firewall doesn't
> mean that it cannot be compromised, and once it is, it can then become
> a source of spam and abuse.  This is not an idle thought experiment; it
> does practically happen with great frequency on the Internet today.  An
> unsupported system might be acceptable if it has no network connectivity
> at all, but then it would not need a newer version of Git.

Aren't you assuming that any network connectivity is equal to connectivity to the open internet?

In any case, I think the notion that we should make git slightly more painful to use on these systems as a distant proxy variable to forcing OS upgrades is several levels away from where I think we should be drawing the line, which is closer to "is it painful in-tree?" and "is someone sending us patches to make it work?" etc.

Previous: brian m. carlsonNext: Bagas Sanjaya
Message 52 of 162 in “dropping support for older curl”
  1. 0/4 dropping support for older curlJeff King, Aug 9, 2017
  2. 1/4 http: drop support for curl < 7.11.1Jeff King, Aug 9, 2017
  3. 2/4 http: drop support for curl < 7.16.0Jeff King, Aug 9, 2017
  4. Stefan BellerAug 9, 2017
  5. Jeff KingAug 9, 2017
  6. Junio C HamanoAug 9, 2017
  7. Nicolas Morey-ChaisemartinAug 9, 2017
  8. Jeff KingAug 9, 2017
  9. Nicolas Morey-ChaisemartinAug 9, 2017
  10. Jeff KingAug 9, 2017
  11. Jeff KingAug 9, 2017
  12. 3/4 http: drop support for curl < 7.19.4Jeff King, Aug 9, 2017
  13. Ævar Arnfjörð BjarmasonAug 9, 2017
  14. Jeff KingAug 9, 2017
  15. 5/4 curl: remove ifdef'd code never used with curl >=7.19.4Ævar Arnfjörð Bjarmason, Aug 9, 2017
  16. Stefan BellerAug 9, 2017
  17. Jeff KingAug 9, 2017
  18. Mischa POSLAWSKYAug 10, 2017
  19. Jeff KingAug 10, 2017
  20. 4/4 http: #error on too-old curlJeff King, Aug 9, 2017
  21. Stefan BellerAug 9, 2017
  22. Johannes SchindelinAug 9, 2017
  23. Jeff KingAug 9, 2017
  24. Johannes SchindelinAug 10, 2017
  25. Jeff KingAug 10, 2017
  26. Junio C HamanoAug 10, 2017
  27. Jeff KingAug 10, 2017
  28. Jeff KingAug 11, 2017
  29. Tom G. ChristensenAug 10, 2017
  30. Jeff KingAug 10, 2017
  31. Tom G. ChristensenAug 10, 2017
  32. Jeff KingAug 10, 2017
  33. Tom G. ChristensenAug 10, 2017
  34. Jeff KingAug 10, 2017
  35. Tom G. ChristensenAug 10, 2017
  36. Tom G. ChristensenAug 10, 2017
  37. Ævar Arnfjörð BjarmasonAug 9, 2017
  38. 0/5 drop support for ancient curlÆvar Arnfjörð Bjarmason, Jul 21, 2021
  39. 1/5 http: drop support for curl < 7.11.1Ævar Arnfjörð Bjarmason, Jul 21, 2021
  40. Junio C HamanoJul 21, 2021
  41. 2/5 http: drop support for curl < 7.16.0Ævar Arnfjörð Bjarmason, Jul 21, 2021
  42. 3/5 http: drop support for curl < 7.19.4Ævar Arnfjörð Bjarmason, Jul 21, 2021
  43. Junio C HamanoJul 21, 2021
  44. 4/5 http: drop support for curl < 7.19.3 and < 7.16.4 (again)Ævar Arnfjörð Bjarmason, Jul 21, 2021
  45. Junio C HamanoJul 21, 2021
  46. 5/5 http: rename CURLOPT_FILE to CURLOPT_WRITEDATAÆvar Arnfjörð Bjarmason, Jul 21, 2021
  47. Junio C HamanoJul 21, 2021
  48. Junio C HamanoJul 21, 2021
  49. brian m. carlsonJul 21, 2021
  50. Ævar Arnfjörð BjarmasonJul 22, 2021
  51. brian m. carlsonJul 22, 2021
  52. Ævar Arnfjörð BjarmasonJul 23, 2021
  53. Bagas SanjayaJul 22, 2021
  54. Jeff KingJul 23, 2021
  55. Junio C HamanoJul 23, 2021
  56. Randall S. BeckerJul 23, 2021
  57. Jeff KingJul 24, 2021
  58. 0/7 drop support for ancient curl, improve version checksÆvar Arnfjörð Bjarmason, Jul 30, 2021
  59. 1/7 http: drop support for curl < 7.11.1Ævar Arnfjörð Bjarmason, Jul 30, 2021
  60. 2/7 http: drop support for curl < 7.16.0Ævar Arnfjörð Bjarmason, Jul 30, 2021
  61. 3/7 http: drop support for curl < 7.19.4Ævar Arnfjörð Bjarmason, Jul 30, 2021
  62. 5/7 http: drop support for curl < 7.18.0 (again)Ævar Arnfjörð Bjarmason, Jul 30, 2021
  63. Junio C HamanoJul 30, 2021
  64. 4/7 http: drop support for curl < 7.19.3 and <= 7.16.4 (or <7.17.0) (again)Ævar Arnfjörð Bjarmason, Jul 30, 2021
  65. Junio C HamanoJul 30, 2021
  66. 6/7 http: rename CURLOPT_FILE to CURLOPT_WRITEDATAÆvar Arnfjörð Bjarmason, Jul 30, 2021
  67. 7/7 http: centralize the accounting of libcurl dependenciesÆvar Arnfjörð Bjarmason, Jul 30, 2021
  68. Junio C HamanoJul 30, 2021
  69. 0/5 drop support for ancient curlÆvar Arnfjörð Bjarmason, Jul 30, 2021
  70. 1/5 http: drop support for curl < 7.11.1Ævar Arnfjörð Bjarmason, Jul 30, 2021
  71. 2/5 http: drop support for curl < 7.16.0Ævar Arnfjörð Bjarmason, Jul 30, 2021
  72. Andrei RybakSep 10, 2021
  73. Jeff KingSep 11, 2021
  74. Junio C HamanoSep 11, 2021
  75. Jeff KingSep 11, 2021
  76. 3/5 http: drop support for curl < 7.19.4Ævar Arnfjörð Bjarmason, Jul 30, 2021
  77. 4/5 http: drop support for curl < 7.19.3 and < 7.17.0 (again)Ævar Arnfjörð Bjarmason, Jul 30, 2021
  78. 5/5 http: rename CURLOPT_FILE to CURLOPT_WRITEDATAÆvar Arnfjörð Bjarmason, Jul 30, 2021
  79. Junio C HamanoJul 30, 2021
  80. Junio C HamanoJul 30, 2021
  81. Junio C HamanoJul 30, 2021
  82. 0/5 post-v2.33 "drop support for ancient curl" follow-upÆvar Arnfjörð Bjarmason, Sep 8, 2021
  83. 1/5 http: drop support for curl < 7.18.0 (again)Ævar Arnfjörð Bjarmason, Sep 8, 2021
  84. Junio C HamanoSep 9, 2021
  85. 2/5 http: correct curl version check for CURLOPT_PINNEDPUBLICKEYÆvar Arnfjörð Bjarmason, Sep 8, 2021
  86. Jeff KingSep 8, 2021
  87. Junio C HamanoSep 9, 2021
  88. Jeff KingSep 10, 2021
  89. Jeff KingSep 10, 2021
  90. Ævar Arnfjörð BjarmasonSep 10, 2021
  91. Jeff KingSep 10, 2021
  92. Daniel StenbergSep 10, 2021
  93. Ævar Arnfjörð BjarmasonSep 10, 2021
  94. Daniel StenbergSep 10, 2021
  95. 3/5 http: correct version check for CURL_HTTP_VERSION_2_0Ævar Arnfjörð Bjarmason, Sep 8, 2021
  96. Jeff KingSep 8, 2021
  97. 4/5 http: centralize the accounting of libcurl dependenciesÆvar Arnfjörð Bjarmason, Sep 8, 2021
  98. Jeff KingSep 8, 2021
  99. Junio C HamanoSep 9, 2021
  100. Jeff KingSep 9, 2021
  101. 5/5 http: don't hardcode the value of CURL_SOCKOPT_OKÆvar Arnfjörð Bjarmason, Sep 8, 2021
  102. Junio C HamanoSep 9, 2021
  103. Junio C HamanoSep 9, 2021
  104. Jeff KingSep 8, 2021
  105. 0/8 post-v2.33 "drop support for ancient curl" follow-upÆvar Arnfjörð Bjarmason, Sep 10, 2021
  106. 1/8 INSTALL: don't mention the "curl" executable at allÆvar Arnfjörð Bjarmason, Sep 10, 2021
  107. Jeff KingSep 10, 2021
  108. 2/8 INSTALL: mention that we need libcurl 7.19.4 or newer to buildÆvar Arnfjörð Bjarmason, Sep 10, 2021
  109. Jeff KingSep 10, 2021
  110. Junio C HamanoSep 10, 2021
  111. Jeff KingSep 10, 2021
  112. 3/8 Makefile: drop support for curl < 7.9.8 (again)Ævar Arnfjörð Bjarmason, Sep 10, 2021
  113. Jeff KingSep 10, 2021
  114. 4/8 http: drop support for curl < 7.18.0 (again)Ævar Arnfjörð Bjarmason, Sep 10, 2021
  115. 5/8 http: correct version check for CURL_HTTP_VERSION_2Ævar Arnfjörð Bjarmason, Sep 10, 2021
  116. Jeff KingSep 10, 2021
  117. Daniel StenbergSep 10, 2021
  118. Jeff KingSep 10, 2021
  119. Ævar Arnfjörð BjarmasonSep 10, 2021
  120. 6/8 http: correct curl version check for CURLOPT_PINNEDPUBLICKEYÆvar Arnfjörð Bjarmason, Sep 10, 2021
  121. Junio C HamanoSep 10, 2021
  122. 7/8 http: centralize the accounting of libcurl dependenciesÆvar Arnfjörð Bjarmason, Sep 10, 2021
  123. Jeff KingSep 10, 2021
  124. 8/8 http: don't hardcode the value of CURL_SOCKOPT_OKÆvar Arnfjörð Bjarmason, Sep 10, 2021
  125. Jeff KingSep 10, 2021
  126. Jeff KingSep 10, 2021
  127. Ævar Arnfjörð BjarmasonSep 10, 2021
  128. Jeff KingSep 10, 2021
  129. Junio C HamanoSep 10, 2021
  130. Randall S. BeckerSep 10, 2021
  131. Ævar Arnfjörð BjarmasonSep 10, 2021
  132. Junio C HamanoSep 10, 2021
  133. Junio C HamanoSep 10, 2021
  134. Konstantin RyabitsevSep 10, 2021
  135. Junio C HamanoSep 10, 2021
  136. Ævar Arnfjörð BjarmasonSep 10, 2021
  137. 0/9 post-v2.33 "drop support for ancient curl" follow-upÆvar Arnfjörð Bjarmason, Sep 11, 2021
  138. 1/9 INSTALL: don't mention the "curl" executable at allÆvar Arnfjörð Bjarmason, Sep 11, 2021
  139. 2/9 INSTALL: reword and copy-edit the "libcurl" sectionÆvar Arnfjörð Bjarmason, Sep 11, 2021
  140. 3/9 INSTALL: mention that we need libcurl 7.19.4 or newer to buildÆvar Arnfjörð Bjarmason, Sep 11, 2021
  141. 4/9 Makefile: drop support for curl < 7.9.8 (again)Ævar Arnfjörð Bjarmason, Sep 11, 2021
  142. 5/9 http: drop support for curl < 7.18.0 (again)Ævar Arnfjörð Bjarmason, Sep 11, 2021
  143. 6/9 http: correct version check for CURL_HTTP_VERSION_2Ævar Arnfjörð Bjarmason, Sep 11, 2021
  144. 7/9 http: correct curl version check for CURLOPT_PINNEDPUBLICKEYÆvar Arnfjörð Bjarmason, Sep 11, 2021
  145. 8/9 http: centralize the accounting of libcurl dependenciesÆvar Arnfjörð Bjarmason, Sep 11, 2021
  146. 9/9 http: don't hardcode the value of CURL_SOCKOPT_OKÆvar Arnfjörð Bjarmason, Sep 11, 2021
  147. Jeff KingSep 11, 2021
  148. Junio C HamanoSep 12, 2021
  149. 0/9 post-v2.33 "drop support for ancient curl" follow-upÆvar Arnfjörð Bjarmason, Sep 13, 2021
  150. 1/9 INSTALL: don't mention the "curl" executable at allÆvar Arnfjörð Bjarmason, Sep 13, 2021
  151. 2/9 INSTALL: reword and copy-edit the "libcurl" sectionÆvar Arnfjörð Bjarmason, Sep 13, 2021
  152. 3/9 INSTALL: mention that we need libcurl 7.19.4 or newer to buildÆvar Arnfjörð Bjarmason, Sep 13, 2021
  153. 7/9 http: correct curl version check for CURLOPT_PINNEDPUBLICKEYÆvar Arnfjörð Bjarmason, Sep 13, 2021
  154. 6/9 http: correct version check for CURL_HTTP_VERSION_2Ævar Arnfjörð Bjarmason, Sep 13, 2021
  155. 4/9 Makefile: drop support for curl < 7.9.8 (again)Ævar Arnfjörð Bjarmason, Sep 13, 2021
  156. 5/9 http: drop support for curl < 7.18.0 (again)Ævar Arnfjörð Bjarmason, Sep 13, 2021
  157. 8/9 http: centralize the accounting of libcurl dependenciesÆvar Arnfjörð Bjarmason, Sep 13, 2021
  158. 9/9 http: don't hardcode the value of CURL_SOCKOPT_OKÆvar Arnfjörð Bjarmason, Sep 13, 2021
  159. Jeff KingSep 13, 2021
  160. Junio C HamanoSep 13, 2021
  161. Tom G. ChristensenAug 10, 2017
  162. Johannes SchindelinAug 14, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.