Re: [PATCH 3/4] http: drop support for curl < 7.19.4

From: Stefan Beller <sbeller@google.com>
Date: Aug 9, 2017, 17:34 UTC
Message-ID: <CAGZ79kZ-Ra6MCvvq-dqnsXowmykBt9ghqUgHgzSC_zt=Q1_=CA@mail.gmail.com>
In-Reply-To: <20170809120201.2eagzkljervqeusx@sigill.intra.peff.net>

On Wed, Aug 9, 2017 at 5:02 AM, Jeff King <peff@peff.net> wrote:

Show 7 quoted lines

> Since v2.12.0, Git does not compile with versions of curl
> older than 7.19.4. That version of curl is about 8 years
> old. This means it may still be used in some distributions
> with long-running support periods. But the fact that we
> haven't received a single bug report about the compile-time
> breakage implies that nobody cares about building recent
> releases on such platforms.

I would not state it as bland, see how https://public-inbox.org/git/20170806233850.14711-1-avarab@gmail.com/ came here to the mailing list.

Show 5 quoted lines

> As discussed in the previous two commits, this cleans up the
> code and gives a more realistic signal to users about which
> versions of Git are actually tested (in particular, this
> moves us past the potential use-after-free issues with curl
> older than 7.17.0).

This is a good reason for this patch, though, so maybe just elide the "nobody cares" part?

Thanks for these cleanups!