Re: [PATCH v9 00/30] Builtin FSMonitor Part 3
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jun 2, 2022, 09:56 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2206021155070.349@tvgsbejvaqbjf.bet>
- In-Reply-To
- <pull.1143.v9.git.1653601644.gitgitgadget@gmail.com>
Hi Jeff,
On Thu, 26 May 2022, Jeff Hostetler via GitGitGadget wrote:
Show 13 quoted lines
> Here is version 9 of part 3 of FSMonitor. > > This version addresses the test failure on t7527.[56] when deleting/renaming > the .git directory using the "GIT~1" spelling. Between v6 and v7, I changed > the way check_for_shortnames() constructed the wchar_t path to .git from a > pair of wcscpy() calls to a swprintf() call. However, I used a "%s" by > mistake rather than a "%ls". > > This caused a non-portable behavior. The tests passed with MSVC and with GCC > 10.1.0 on my laptop, but failed under GCC on one of the CI build machines. > > This was partially hidden by CI machines that have GCC 12 and that fail to > compile Git without the fixes for GCC 12.x.
I was already happy with the range-diff you showed in v7, and I am even happier with the `hexdump` changes you introduced in v8 and with the `swprintf()` format fix in v9.
From my side, this patch series is ready for `next`.
Thank you, Dscho