Re: [PATCH v8 00/30] Builtin FSMonitor Part 3
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- May 25, 2022, 17:29 UTC
- Message-ID
- <5224e941-af0d-d478-00f0-cf6639e3a726@jeffhostetler.com>
- In-Reply-To
- <xmqqy1yp8ta2.fsf@gitster.g>
On 5/25/22 12:35 PM, Junio C Hamano wrote:
Show 13 quoted lines
> "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes: > >> This version addresses the new t/helper/test-hexdump utility to emit an LF >> at the end. I also updated the test scripts to write hexdump output to a >> file and then grep that file to avoid having the tool being in the middle of >> a pipeline. > > https://github.com/git/git/runs/6583917870 shows t7527 is not happy > in "win test (9)" job with the previous version. It is unclear if > that has been addressed, but we'll see soon. > > Will replace. Thanks. >
I'll investigate. Thanks.
An earlier version had a "mv .git foo; sleep 1; mv foo .git" and then tested to see if the daemon had noticed the change and automatically shutting down. That was a little racy on very slow build machines (well, that was the only place that it was seen). So added `verify_implicit_shutdown()` to try to make it less sensitive. Looks like it might need a little more help.
Jeff