Re: [PATCH 04/23] t/helper/fsmonitor-client: create stress test
- From
Derrick Stolee <derrickstolee@github.com>
- Date
- Feb 24, 2022, 14:58 UTC
- Message-ID
- <ab3d1fc7-e63a-dff4-f373-a6ac32b8294a@github.com>
- In-Reply-To
- <9efdbe28223e371dc22b4ba32fc791729af5577a.1644940773.git.gitgitgadget@gmail.com>
On 2/15/2022 10:59 AM, Jeff Hostetler via GitGitGadget wrote:
Show 9 quoted lines
> From: Jeff Hostetler <jeffhost@microsoft.com> > > Create a stress test to hammer on the fsmonitor daemon. > Create a client-side thread pool of n threads and have > each of them make m requests as fast as they can. > > NEEDSWORK: This is just the client-side thread pool and > is useful for interactive testing and experimentation. > We need to add a script test to drive this.
I haven't gotten far enough in the series to know if you _do_ use this in a test eventually. If so, this NEEDSWORK could be replaced with a mention of a future change.
> + /* > + * TODO Decide if/when to return an error or call die(). > + */ > + return 0;
This TODO could be cleaned up.
Thanks, -Stolee