Re: [PATCH 00/23] Builtin FSMonitor Part 3

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Feb 16, 2022, 14:04 UTC
Message-ID: <0e9f0152-4421-976b-51ff-8687c7f5d329@jeffhostetler.com>
In-Reply-To: <xmqqv8xfy6ab.fsf@gitster.g>

On 2/15/22 8:00 PM, Junio C Hamano wrote:

Show 20 quoted lines

> "Jeff Hostetler via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> Here is part 3 of my builtin FSMonitor series.
>>
>> Part 3 builds upon part 2 (jh/builtin-fsmonitor-part2) which is currently in
>> "seen", so this series should be considered a preview until part 2 moves to
>> "next". (And part 2 should not graduate to "master" without this part.)
>>
>> Part 2 established the client code (used by commands like git status) and an
>> MVP implementation of the FSMonitor daemon. This was sufficient to test the
>> concepts and basic functionality.
> 
> Sounds like part 2 is sufficiently done to be eligible for being in
> 'master', waiting for an improved daemon, no?
> 
> Have people been reviewing the patches in part 2?  I haven't had a
> chance to take a deeper look myself.
> 
> Thanks.
>

Yes, I think Part 2 could advance if we wanted to. I just didn't want to presume that, so I was being conservative. I've always treated it and Part 3 as a unit.

On the other hand, we've been distributing Part 2 V4 and an un-submitted version of Part 3 experimentally in git-for-windows and microsoft/git.git (gvfs) since last summer, so I think we're good.

It would be good to get some eyes on the Part 2 V5 changes having to do with removing `core.useBuiltinFSMonitor` and overloading the existing `core.fsmonitor` to take either a hook path or bool. That was the only major change between V4 and V5. And that V5 change has not yet been shipped in GFW nor GVFS.

Thanks Jeff