Re: [PATCH v2 25/27] t/lib-unicode-nfc-nfd: helper prereqs for testing unicode nfc/nfd
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Mar 10, 2022, 14:28 UTC
- Message-ID
- <1b35ccf2-fe23-145d-53b9-4a0cbb5bba8b@jeffhostetler.com>
- In-Reply-To
- <6555f3dc-e72c-2b0f-fe66-d81d48dff6f7@github.com>
On 3/9/22 1:42 PM, Derrick Stolee wrote:
Show 19 quoted lines
> On 3/9/2022 1:40 PM, Derrick Stolee wrote: >> On 3/8/2022 5:15 PM, Jeff Hostetler via GitGitGadget wrote: >>> From: Jeff Hostetler <jeffhost@microsoft.com> >>> >>> Create a set of prereqs to help understand how file names >>> are handled by the filesystem when they contain NFC and NFD >>> Unicode characters. >> >> Prereqs look good and are well documented. >> >>> +if test $unicode_debug = 1 >> >> Is this $unicode_debug something I should know from a previous >> patch? or is it a leftover from local debugging? > > I see that you set unicode_debug = 0 in a later patch, but I > suppose that we might want this output no matter what. Or, do > we think it will interrupt the output parsing of 'prove' and > other tools?
I was afraid that it might interrupt tools like prove, but I just tried it and it didn't. But yeah it would be safer to turn it off until someone actually wants to do some debugging in this area.
Jeff