Re: [PATCH v2 25/27] t/lib-unicode-nfc-nfd: helper prereqs for testing unicode nfc/nfd

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Mar 10, 2022, 14:23 UTC
Message-ID: <0ba86794-e932-b443-2483-b93b171766f0@jeffhostetler.com>
In-Reply-To: <af6c456a-d49f-e0f2-50ae-f44fdb6351e3@github.com>

On 3/9/22 1:40 PM, Derrick Stolee wrote:

Show 13 quoted lines

> On 3/8/2022 5:15 PM, Jeff Hostetler via GitGitGadget wrote:
>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>
>> Create a set of prereqs to help understand how file names
>> are handled by the filesystem when they contain NFC and NFD
>> Unicode characters.
> 
> Prereqs look good and are well documented.
> 
>> +if test $unicode_debug = 1
> 
> Is this $unicode_debug something I should know from a previous
> patch? or is it a leftover from local debugging?

I added that and all of the print statements to help describe the characteristics of the (OS, FS) pair, for example what happens on (MacOS, FAT32) and is that any different from (MacOS, APFS). I found this very useful in trying to decipher the docs.

However, it is kinda noisy and appears directly on the console. Since most people don't need to see it (unless they are working on Unicode/UTF8 issues), I decided to turn it off for now.

I'm not sure if we have a way to handle such output or not. I thought about maybe hooking it into the -d or -x options, but I'm not sure if that helps or not. So I just turned it off.

Also, by not always testing the prereqs just to print the result here, we avoid actually doing the lazy evals until a real test wants to use one of them.

I'll add a comment in the script documenting it.

Thanks Jeff