Re: [PATCH v7 26/30] t/helper/hexdump: add helper to print hexdump of stdin
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- May 25, 2022, 10:21 UTC
- Message-ID
- <nycvar.QRO.7.76.6.2205251220260.352@tvgsbejvaqbjf.bet>
- In-Reply-To
- <xmqqbkvmhfoc.fsf@gitster.g>
Hi Junio,
On Tue, 24 May 2022, Junio C Hamano wrote:
Show 8 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes: > > > Do you know of any `grep` implementation that has problems with text > > missing the usual trailing newlines? > > I recall that we had reports on BSD variants, but please do not > quote me on that. Perhaps all the BSD variants are good now, or > perhaps some aren't.
I did not recall any such reports, but take your word for it.
> In any case, I do not take the "if it works on Windows and Linux, we > do not care about the rest of the world" world view,
Just in case it was unclear to you: we're on the same page here.
Show 7 quoted lines
> so finding the answer to that question unfortunately does not give much > input to the issue in either way. > > And in this particular case, it is much simpler to mak sure that the > file does not end in an incomplete line than us exchanging e-mails > back and forth, so that would be the most economical solution I > would prefer.
Indeed, the trailing newline is easily added and fixes a known issue, so I'm all for it.
Ciao, Dscho