Re: [PATCH v2 00/27] Builtin FSMonitor Part 3

From: Derrick Stolee <derrickstolee@github.com>
Date: Mar 9, 2022, 18:48 UTC
Message-ID: <45b381da-af41-9e6b-f3b6-a83678a20319@github.com>
In-Reply-To: <pull.1143.v2.git.1646777727.gitgitgadget@gmail.com>

On 3/8/2022 5:15 PM, Jeff Hostetler via GitGitGadget wrote:

> Here is V2 of part 3 of my builtin FSMonitor series.
> 
> I think I have addressed all of the feedback from V1. This includes:

> Range-diff vs v1:

Show 5 quoted lines

>   -:  ----------- > 22:  524d449ed64 fsmonitor: never set CE_FSMONITOR_VALID on submodules
>   -:  ----------- > 24:  95b9d4210d2 fsmonitor: on macOS also emit NFC spelling for NFD pathname
>   -:  ----------- > 25:  5a0c1b7a287 t/lib-unicode-nfc-nfd: helper prereqs for testing unicode nfc/nfd
>   -:  ----------- > 26:  a45c1fd3000 t7527: test Unicode NFC/NFD handling on MacOS
>   -:  ----------- > 27:  e3e01677d93 fsmonitor-settings: NTFS and FAT32 on MacOS are incompatible

I looked closely through the range-diff for the edits, then looked at these new patches closely. Outside of one thought about some debug output, I'm happy with this version.

Thanks, -Stolee

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.